Just a note for people with color-inverted icons when highlighted:
You solve it in WinXP by using HBMMENU_CALLBACK.
In this case you are responsible for drawing the image.

For Vista and later (even with classic theme) you can use the ARGB bitmap and everything look stunning!

HC @ Lammersoft

inline BOOL ReplaceDIBColor(HBITMAP* pDIB, COLORREF oldColor,COLORREF newColor)
{
_ASSERTE(pDIB!=NULL);
if (pDIB==NULL) return FALSE;
if (oldColor==newColor) return TRUE;//nothing to do
BOOL bRet=FALSE;

//get color information
DIBSECTION ds;
if (!::GetObject(*pDIB, sizeof(DIBSECTION), &ds)) return FALSE;
UINT nColors = ds.dsBmih.biClrUsed ? ds.dsBmih.biClrUsed : 1<8 || nColors>256) return FALSE;//8bpp is max

HDC hDC=::CreateCompatibleDC(NULL);
if (!hDC) return FALSE;
HBITMAP hbmpOld=(HBITMAP)::SelectObject(hDC, *pDIB);
if (hbmpOld!=NULL)
{ //replace color table entries
RGBQUAD clrtbl[256*sizeof(RGBQUAD)];
if (::GetDIBColorTable(hDC, 0, nColors, clrtbl))
{
UINT i;
for (i=0; i<nColors; i++)
{
if (oldColor==RGB(clrtbl[i].rgbRed, clrtbl[i].rgbGreen, clrtbl[i].rgbBlue))
{
clrtbl[i].rgbRed=GetRValue(newColor);
clrtbl[i].rgbGreen=GetGValue(newColor);
clrtbl[i].rgbBlue=GetBValue(newColor);
bRet=TRUE;
}
}
if (bRet)//set new table
if (!::SetDIBColorTable(hDC, 0, nColors, clrtbl)) bRet=FALSE;
}
*pDIB=(HBITMAP)::SelectObject(hDC, hbmpOld);
}
::DeleteDC(hDC);
return bRet;
}

I’m trying to implement a shell extension that extends IContextMenu3 and IShellExtInit, and i’m inserting menu items using the method described in section “HBMMENU_CALLBACK method” but in my project the method HandleMenuMsg2 or the HandleMenuMsg is never called.

Can anyone please explain me what is required to receive the HandleMenuMsg2 calls?

My ATL object is implemented like that:

// CTestPlugin
class ATL_NO_VTABLE CTestPlugin :
public CComObjectRootEx<CComMultiThreadModel>,
public CComCoClass<CTestPlugin, &CLSID_CTestPlugin>,
public IShellExtInit,
public IContextMenu3
{
public:
DECLARE_REGISTRY_RESOURCEID(IDR_TESTPLUGIN)
DECLARE_NOT_AGGREGATABLE(CTestPlugin)
BEGIN_COM_MAP(CTestPlugin)
COM_INTERFACE_ENTRY(IShellExtInit)
COM_INTERFACE_ENTRY(IContextMenu)
COM_INTERFACE_ENTRY(IContextMenu2)
COM_INTERFACE_ENTRY(IContextMenu3)
END_COM_MAP()
DECLARE_PROTECT_FINAL_CONSTRUCT()
…
// IShellExtInit
STDMETHODIMP Initialize(LPCITEMIDLIST, LPDATAOBJECT, HKEY);

// IContextMenu
STDMETHODIMP GetCommandString(UINT, UINT, UINT*, LPSTR, UINT)
{ return S_OK; }
STDMETHODIMP InvokeCommand(LPCMINVOKECOMMANDINFO);
STDMETHODIMP QueryContextMenu(HMENU, UINT, UINT, UINT, UINT);
// IContextMenu2
STDMETHODIMP HandleMenuMsg(UINT uMsg, WPARAM wParam, LPARAM lParam);
// IContextMenu3
STDMETHODIMP HandleMenuMsg2(UINT uMsg, WPARAM wParam, LPARAM lParam, LRESULT *pResult);

And i’m inserting menu items like described in the nanoANT page:

bool CTestPlugin::AddNewMenuItem(HMENU hmenu, UINT un_menu_text_id, UINT un_menu_index, UINT icon, UINT& uCmdID)
{
TCHAR chText[MAX_PATH];
::LoadString(
_AtlModule.m_hResInstance,
un_menu_text_id,
chText,
MAX_PATH);

MENUITEMINFO menuiteminfo;
ZeroMemory(&menuiteminfo, sizeof(menuiteminfo));
menuiteminfo.cbSize = sizeof(menuiteminfo);
menuiteminfo.fMask = MIIM_FTYPE | MIIM_ID | MIIM_SUBMENU | MIIM_DATA | MIIM_BITMAP | MIIM_STRING;
menuiteminfo.fType = MFT_STRING;
menuiteminfo.dwTypeData = chText;
menuiteminfo.cch = _tcslen(chText);
if (icon) {
menuiteminfo.hbmpItem =
SysInfo::Instance().IsVistaOrLater()
?
_AtlModule.m_iconBitmapUtils.IconToBitmapPARGB32(_AtlModule.m_hResInstance, icon)
:
HBMMENU_CALLBACK;
}
menuiteminfo.wID        = (UINT)uCmdID++;
m_mapIdToIcon[menuiteminfo.wID] = icon;
return (TRUE==InsertMenuItem(hmenu, un_menu_index, TRUE, &menuiteminfo));
}
STDMETHODIMP CTestPlugin::HandleMenuMsg(UINT uMsg, WPARAM wParam, LPARAM lParam)
{
LRESULT res;
return HandleMenuMsg2(uMsg, wParam, lParam, &res);
}

STDMETHODIMP CTestPlugin::HandleMenuMsg2(UINT uMsg, WPARAM wParam, LPARAM lParam, LRESULT *pResult)
{
…
}

With all this the menu entries apear in explorer context menu but no images are displayed, both methods HandleMenuMsg and HandleMenuMsg2 are never called, and the system that i’m testing is WinXP (in vista all is ok because we use the hbmpItem).

I’m missing some inicialization or what? can anyone explain me?

Thanks

http://social.msdn.microsoft.com/Forums/en-US/windowsuidevelopment/thread/b3dde0f6-b20b-4a96-885e-f72bad3a2ae6

Ad. Carlos, Peter: hbmp(Un)checked method always inverts the icon on highlight, moreover icons are squashed – not rendered full 16×16 size (as you can see on the 1st screenshot). While this may be acceptable on not really pretty Windows 2000 UI, on Vista it just looks ugly. So pure GDI way on Vista is the best way I presume now and it is how TortoiseSVN is now.

For a full implementation code please have a look at: http://guest@tortoisesvn.tigris.org/svn/tortoisesvn/trunk/src/TortoiseShell/ContextMenu.cpp

Mark: I am very sorry but I don’t use VB really. Just updated the Vista method to pure GDI way, maybe you can just have it working with VB6 too instead of dealing with GDI+